Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cloud transfer requires ETag + https redirector on port 8081 #80

Merged
merged 4 commits into from
Jan 12, 2018
Merged

Cloud transfer requires ETag + https redirector on port 8081 #80

merged 4 commits into from
Jan 12, 2018

Conversation

ldemailly
Copy link
Member

@ldemailly ldemailly commented Jan 11, 2018 •
edited
Loading

fix for b/70993367 and istio/istio#1377

douglas-reid
douglas-reid reviewed Jan 11, 2018
View reviewed changes
Copy link

@douglas-reid douglas-reid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@codecov
Copy link

codecov bot commented Jan 11, 2018 •
edited
Loading

Codecov Report

Merging #80 into master will decrease coverage by 0.1%.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           master     #80     +/-   ##
========================================
- Coverage    82.2%   82.2%   -0.1%     
========================================
  Files           6       6             
  Lines        1311    1311             
========================================
- Hits         1078    1077      -1     
- Misses        163     164      +1     
  Partials       70      70
Impacted Files Coverage Δ
periodic/periodic.go 97.1% <ø> (ø) ⬆️
fhttp/http.go 69.7% <0%> (-0.2%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0f36c2d...689547c. Read the comment docs.

@ldemailly ldemailly changed the title Cloud transfer require ETag Cloud transfer requires ETag Jan 12, 2018
@ldemailly
Adding a redirector to https
5df58cb 
As a workaround for
istio/istio#1377
To be used in combo with ingress rules from
istio/fortio-deployment#32
@ldemailly ldemailly changed the title Cloud transfer requires ETag Cloud transfer requires ETag + https redirector on port 8081 Jan 12, 2018
@ldemailly
Copy link
Member Author

ldemailly commented Jan 12, 2018 •
edited
Loading

@douglas-reid I made an additional change if you can have a quick look:
5df58cb

it's to make http://fortio.istio.io/ work/redirect to https://fortio.istio.io/ (in conjunction with istio/fortio-deployment#32 )

Both PRs are live so you can give it a try if you want

@ldemailly ldemailly merged commit 2e43a2a into master Jan 12, 2018
@ldemailly ldemailly deleted the tsv-fix branch January 12, 2018 17:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@douglas-reid douglas-reid douglas-reid approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ldemailly @douglas-reid